-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix diagnostics page for light miner #521
Comments
FYI @MuratUrsavas ^^ |
@shawaj Should I remove that old residue, then? It is working well in current state (with template_hyper) |
@shawaj It's stub now, we can easily remove that. Let's do this in next change. No need to deal with it for two PR's. |
ahh so this template diagnostics_page_light_miner.html is not being used? Also - it looks like diagnostics.RE in here is checking for UN123 - but I think you deprecated that functionality now in this latest update? So I guess we need to change how it checks for radio operational and region plan... hm-diag/hw_diag/templates/helium_info.html Lines 60 to 82 in d784407
|
@MuratUrsavas what will it show if the location is not asserted? |
hm-diag/hw_diag/templates/diagnostics_page_light_miner.html Lines 109 to 116 in d784407
|
I don't think this will work: https://github.com/NebraLtd/hm-diag/blob/d7844079b924daf171b5588b0142ff782c6ea599/hw_diag/templates/diagnostics_page_light_miner.html
As this is the new format:
https://github.com/NebraLtd/hm-diag/blob/d7844079b924daf171b5588b0142ff782c6ea599/hw_diag/templates/helium_info.html
The text was updated successfully, but these errors were encountered: