Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement standardized build pipeline based on existing repos #25

Closed
pritamghanghas opened this issue Mar 17, 2022 · 1 comment
Closed

Implement standardized build pipeline based on existing repos #25

pritamghanghas opened this issue Mar 17, 2022 · 1 comment
Assignees
@pritamghanghas

Comments

@pritamghanghas
Copy link
Contributor

pritamghanghas commented Mar 17, 2022 •
edited by marvinmarnold
Loading

As a user of this repository, any new push should result in workflow triggers that do linting and dockerfile builds.

  • cleanup the dockerfile build and startup script.
  • verify that gateway miner runs on the device with ecc.
  • update workflow trigger similar to hm-miner

Acceptance Criterion

  • a new release of upstream gateway-rs results in auto bumping the dockerfile and corresponding dispatch to helium-miner-software
  • Linting workflow actions for dockerfile, code, spellcheck and security. Copy linting settings from hm-confing and hotspot-production-tool.
  • docker builds on every push.
  • Add CODEOWNERS and CONTRIBUTING. Copy from existing repos.
    • Device team should be code owners.
@pritamghanghas pritamghanghas self-assigned this Mar 17, 2022
pritamghanghas added a commit that referenced this issue Mar 18, 2022
@pritamghanghas
Dockerfile and workflow testing and cleanup #25
8603541 
* clean and fix start-gateway.sh
* introduce gen-region.sh
* make sure github actions run successfuly
pritamghanghas added a commit that referenced this issue Mar 18, 2022
@pritamghanghas
Dockerfile and workflow testing and cleanup #25
3e02179 
* clean and fix start-gateway.sh
* introduce gen-region.sh
* make sure github actions run successfuly
pritamghanghas added a commit that referenced this issue Mar 18, 2022
@pritamghanghas
Dockerfile and workflow testing and cleanup #25
1cbae8f 
* clean and fix start-gateway.sh
* introduce gen-region.sh
* make sure github actions run successfuly
@marvinmarnold
Copy link
Contributor

@pritamghanghas FYI I just updated the AC

@marvinmarnold marvinmarnold changed the title Dockerfile and workflow testing and cleanup Implement standardized build pipeline based on existing repos Mar 18, 2022
pritamghanghas added a commit that referenced this issue Mar 21, 2022
@pritamghanghas
Dockerfile and workflow testing and cleanup #25
ee3c647 
* clean and fix start-gateway.sh
* introduce gen-region.sh
* make sure github actions run successfuly
pritamghanghas added a commit that referenced this issue Mar 21, 2022
@pritamghanghas
Dockerfile and workflow testing and cleanup #25
409c974 
* clean and fix start-gateway.sh
* introduce gen-region.sh
* make sure github actions run successfuly
pritamghanghas added a commit that referenced this issue Mar 23, 2022
@pritamghanghas
Dockerfile and workflow testing and cleanup #25
e0cbd18 
* clean and fix start-gateway.sh
* introduce gen-region.sh
* make sure github actions run successfuly
pritamghanghas added a commit that referenced this issue Mar 23, 2022
@pritamghanghas
Dockerfile and workflow testing and cleanup #25
08d5027 
* clean and fix start-gateway.sh
* introduce gen-region.sh
* make sure github actions run successfuly
@pritamghanghas pritamghanghas mentioned this issue Mar 23, 2022
Merged
@shawaj shawaj mentioned this issue Mar 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pritamghanghas pritamghanghas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marvinmarnold @pritamghanghas