Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made FREQ parameter optional #126

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Made FREQ parameter optional #126

merged 1 commit into from
Feb 6, 2023

Conversation

MuratUrsavas
Copy link
Contributor

@MuratUrsavas MuratUrsavas commented Feb 6, 2023 •
edited by shawaj
Loading

Issue

Closes: #123

How

FREQ is not mandatory parameter anymore. In absence, just gives a warning and let the container run.

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@MuratUrsavas MuratUrsavas self-assigned this Feb 6, 2023
@MuratUrsavas MuratUrsavas requested a review from a team as a code owner February 6, 2023 08:17
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MuratUrsavas MuratUrsavas merged commit 1ed62e7 into master Feb 6, 2023
@shawaj shawaj mentioned this pull request Feb 6, 2023
Closed
@MuratUrsavas MuratUrsavas deleted the murat/make-freq-optional branch February 6, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawaj shawaj shawaj approved these changes

Assignees

@MuratUrsavas MuratUrsavas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setenv does not work properly with non-nebra fleets
2 participants
@MuratUrsavas @shawaj