This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
Explorer refactor - Enable a new generation of Sia applications #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashbender
changed the title
|
I like a lot of these changes but we need to split this into multiple PRs -- approximately one PR for each of your bullet points. I'm thinking:
|
…spending fix TestAllowanceSpending failing on AppVeyor
first stab at limiter
try to fix some NDFs
fixes NebulousLabs#2474, adds contributing.md file
…y-search Modify the wallets Transactions function to use binary search
…e filepath.Ext also returns the dot
Multi-block acceptance inconsistency fix
Consensus change debug logging
…-height Add wallet consensus height to /wallet endpoint
add password confirmation to siac wallet
add SIGBUS handler
add logging to narrow in on bittrex timeout bug
attempt to clean up smux concurrency
…-height Cleanup of wallet height PR
# Conflicts: # cmd/siad/daemon.go # modules/explorer/explorer.go # node/api/routes.go # node/api/server_helpers_test.go
z3003g
approved these changes
Mar 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) Block query ranges. You can provide a to and from query parameter with a maximum of 10 blocks to retrieve
2.) Websockets for consensus and pending transaction updates. This will be the most interesting change, since it will enable real-time sites. Websockets enable server push mechanisms, so data will be available to clients in real time.
3.) HashType bucket. To keep from having to lookup into every hash bucket, we keep track of the hash type as it's inserted. This acts as an index and gives us a constant-time lookup of hashes without having to scan every hash bucket
4.) Consistency fixes. I've removed some logic which causes the explorer to fail. This makes the explorer more resilient and reduces the instance of "block not found" errors in the explorer.
5.) In memory pending block. We keep a copy of the current, pending block in memory. This allows us to add/remove transactions and update block facts without having to commit to any DB when pending txs are received