This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
Convert /wallet/encrypt to /wallet/init #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to reference the issue: #752 Edit: Just noticed that was a 4 when it should have been 2 on the issue |
| // walletEncryptHandler handles API calls to /wallet/encrypt. | ||
| // Replaced with /wallet/init kept for compatability |
There was a problem hiding this comment.
first word of the docstring should be the function name.
Also, need to add a COMPAT message.
Something like this:
// walletEncryptHandler is a legacy alias for walletInitHandler.
//
// COMPATv0.4.0
|
Aye! It passes. |
|
Just squashed those messy commits. |
DavidVorick
added a commit
that referenced
this pull request
Aug 31, 2015
Convert /wallet/encrypt to /wallet/init
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested but I see no reason this shouldn't work... let me know if I did something silly.