-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for terser-webpack-plugin (webpack@4.26.0+) #426
Comments
@pleunv thanks for the report 👍 |
I tried to patch offline-plugin in my forked branch about this issue. What I did was simply passing I will try to clean up the implementation and submit a PR. |
@GGAlanSmithee I've submitted the PR. Any chance you can merge it? |
Webpack 4.26.0 switched from using
uglifyjs-webpack-plugin
toterser-webpack-plugin
. Since OfflinePlugin seems to partly piggyback off webpack's minifier but also contains uglifyjs-specific code this is now throwing up the following error:Messed around a little bit myself but adding terser support while maintaining uglifyjs support for
< webpack@4.26.0
involves a bit more than updating the import, unfortunately.Those running into this issue can meanwhile explicitly add
uglifyjs-webpack-plugin
to the dev dependencies until this is resolved.The text was updated successfully, but these errors were encountered: