Add ArrayTools to remove value in an array #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awkan
force-pushed
the
feature/array-tools
branch
7 times, most recently
from
47b3428
to
a5d7a5b
Compare
Nek-
requested changes
Jul 12, 2018
| @@ -5,7 +5,11 @@ | |||
| "autoload": { | |||
| "psr-4": { "Nekland\\Tools\\": "src/" } | |||
| }, | |||
| "require": { | |||
| "php": "^5.6 || ^7.0" | |||
There was a problem hiding this comment.
>=5.6 looks better! But nice change idea.
There was a problem hiding this comment.
^5.6 or ^7.0 is covering all PHP versions 😉
composer.json
Outdated
| "require-dev": { | ||
| "phpspec/phpspec": "^2.5" | ||
| "phpspec/phpspec": "^3.2", |
There was a problem hiding this comment.
Can you add a comment:
"_comment": "Not 4.x because we support PHP 5.6"I'm not sure comments works everywhere, but well if it does, I think that's cool.
Awkan
force-pushed
the
feature/array-tools
branch
from
a5d7a5b
to
ba5cd12
Compare
Awkan
force-pushed
the
feature/array-tools
branch
from
ba5cd12
to
ce9b55d
Compare
Nek-
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pain to always make a loop to check array values and remove one if needed. This PR creates a new Tools:
ArrayTools.It allows to make some processing in array.