Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the height of the header in pixels #44

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

elchininet
Copy link
Collaborator

@elchininet elchininet commented Apr 7, 2023

Kiosk mode sets the height of the header in 0 changing the --header-height variable. This variable is used to set the height of the #view element in this way:

height: calc(100vh - var(--header-height) - env(safe-area-inset-top))

And 100vh - 0 fails because 0 doesn‘t have units. This is problematic with those themes that set a background in this specific element.

This pull request changes the value of the variable --header-height in 0px something that will fix this issue.

Closes #43

@elchininet
Copy link
Collaborator Author

Hi @NemesisRE,
Please, check this one. It is a small change to fix #43.
Regards

@NemesisRE NemesisRE merged commit 54bed40 into master Apr 7, 2023
@elchininet elchininet deleted the set_view_height_in_px branch April 7, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lovelace view issue crop when updated v1.8.1
2 participants