Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare is_one, is_zero as early as possible #1178

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Conversation

fingolfin
Copy link
Member

Also export them explicitly (before @alias did it for us), and use @alias for
our LinearAlgebra aliases, too (makes it easier to find them by grepping)

CC @HechtiDerLachs this is what I was talking about

Also export them explicitly (before @alias did it for us), and use @alias for
our LinearAlgebra aliases, too (makes it easier to find them by grepping)
Taken from Nemo, Hecke, Oscar
@fingolfin
Copy link
Member Author

I've now updated this to also declare more aliases, taken from Nemo/Hecke/Oscar. The idea being that all of our packages should be able to freely and consistently use these aliases.

@thofma
Copy link
Member

thofma commented Jun 8, 2022

Makes sense

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1178 (bddb29c) into master (809bc71) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
- Coverage   85.02%   84.98%   -0.04%     
==========================================
  Files          97       97              
  Lines       26761    26761              
==========================================
- Hits        22753    22744       -9     
- Misses       4008     4017       +9     
Impacted Files Coverage Δ
src/AbstractAlgebra.jl 50.42% <ø> (ø)
src/generic/PuiseuxSeries.jl 86.68% <0.00%> (-0.26%) ⬇️
src/generic/MPoly.jl 94.53% <0.00%> (-0.15%) ⬇️
src/Matrix.jl 91.58% <0.00%> (-0.13%) ⬇️
src/Poly.jl 92.16% <0.00%> (ø)
src/MatrixAlgebra.jl 92.71% <0.00%> (ø)
src/generic/RelSeries.jl 94.16% <0.00%> (ø)
src/generic/SparsePoly.jl 28.46% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809bc71...bddb29c. Read the comment docs.

@fingolfin
Copy link
Member Author

Tests are passing now (except for codecov coverage dropping minimally due to added code)

@thofma thofma merged commit e10e86d into master Jun 9, 2022
@thofma thofma deleted the mh/early-aliases branch June 9, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants