Drop caching from matrix spaces and algebras #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am working on a follow-up PR which will eliminate the need for custom MatSpace subtypes (at least all existing ones can be replaced by it, of course in theory someone might want to store extra data in a mat space, then that would be different; but we don't do that right now). But that code requires some more changes than I expected; so I thought it would be good to already submit this bit, which is already useful on its own. |
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
==========================================
- Coverage 85.81% 85.59% -0.22%
==========================================
Files 102 101 -1
Lines 27879 27867 -12
==========================================
- Hits 23923 23854 -69
- Misses 3956 4013 +57
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Also turn their generic implementations into non-mutable structs, so instances can be stack allocated and does not need caching. This will soon be the case for all matrix space implementations. That's why caching is not necessary anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also turn their generic implementations into non-mutable structs, so
instances can be stack allocated and does not need caching. This will
soon be the case for all matrix space implementations. That's why
caching is not necessary anymore.