Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stage the downstream tests #1599

Merged
merged 1 commit into from
Feb 10, 2024
Merged

ci: stage the downstream tests #1599

merged 1 commit into from
Feb 10, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Feb 10, 2024

No description provided.

@thofma
Copy link
Member Author

thofma commented Feb 10, 2024

@benlorenz I think this is what you suggested, right?

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8b22bf) 87.17% compared to head (0440e68) 87.02%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
- Coverage   87.17%   87.02%   -0.16%     
==========================================
  Files         115      115              
  Lines       29565    29603      +38     
==========================================
- Hits        25773    25761      -12     
- Misses       3792     3842      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit d6e0bc1 into master Feb 10, 2024
28 of 30 checks passed
@thofma thofma deleted the th/citweak branch February 10, 2024 12:49
@benlorenz
Copy link
Collaborator

Yes, something like that, it did seem to work.
With some extra effort (renaming jobs and variables) it might also be possible to put it into one file and make subsequent parts depend on the previous results.

@thofma
Copy link
Member Author

thofma commented Feb 10, 2024

Yes, seems to work. I am quite happy with it, so I don't think we need this functionality in OscarDevTools itself.

ooinaruhugh pushed a commit to ooinaruhugh/AbstractAlgebra.jl that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants