Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FreeAssAlgebra and FreeAssAlgElem #1779

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

lgoettgens
Copy link
Collaborator

Progress towards oscar-system/Oscar.jl#4043.

Copy link
Contributor

@Sequenzer Sequenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you :) 🔥

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 99.04762% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.04%. Comparing base (5fb6da5) to head (4d515d3).
Report is 1 commits behind head on master.

Files Patch % Lines
src/generic/FreeAssociativeAlgebra.jl 98.55% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1779   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         117      117           
  Lines       30092    30092           
=======================================
  Hits        26494    26494           
  Misses       3598     3598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens requested a review from thofma August 28, 2024 13:08
@lgoettgens lgoettgens merged commit 8d1047a into Nemocas:master Aug 28, 2024
30 checks passed
@lgoettgens lgoettgens deleted the lg/rename-freeassalgebra branch August 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants