Refactor MatrixSpace implementation #1433
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress and a proof of concept. Assuming all passes here, too, the next step would be to replace the
AbstractAlgebra.Generic.MatSpace
implementation with theGenericMatSpace
type defined in this PR, and then hopefully we can kill all otherMatSpace
subtypes.This also removes most of the performance overhead involved in using matrix spaces as matrix factories. Indeed, consider these test functions:
Timings before this PR:
Timings with this PR: