Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MatrixView inheritance #1687

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Fix MatrixView inheritance #1687

merged 3 commits into from
Feb 26, 2024

Conversation

lgoettgens
Copy link
Collaborator

Resolves #1685.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.54%. Comparing base (4a1abac) to head (62a0379).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1687      +/-   ##
==========================================
+ Coverage   84.53%   84.54%   +0.01%     
==========================================
  Files          94       94              
  Lines       37084    37084              
==========================================
+ Hits        31348    31353       +5     
+ Misses       5736     5731       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma
Copy link
Member

thofma commented Feb 26, 2024

Thanks! Could you add a view(M, i, :) isa AbstractVector{...} test somewhere?

@thofma thofma enabled auto-merge (squash) February 26, 2024 11:20
@thofma thofma merged commit 1c976c9 into Nemocas:master Feb 26, 2024
15 checks passed
@lgoettgens lgoettgens deleted the lg/matview branch February 26, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong inheritence of MatrixView
2 participants