Deprecate coefficient_ring for the p-adics
#1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
force-pushed
the
js/padicsbreaking
branch
2 times, most recently
from
3e508c0
to
64a09d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
- Coverage 86.18% 86.16% -0.02%
==========================================
Files 98 99 +1
Lines 36208 36273 +65
==========================================
+ Hits 31206 31256 +50
- Misses 5002 5017 +15 ☔ View full report in Codecov by Sentry. |
joschmitt
force-pushed
the
js/padicsbreaking
branch
from
64a09d6
to
30523d9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
joschmitt
force-pushed
the
js/padicsbreaking
branch
from
ebb12bf
to
6f0b9a2
Compare
joschmitt
changed the title
coefficient_ring for the p-adics
lgoettgens
reviewed
Sep 11, 2024
lgoettgens
reviewed
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with thofma/Hecke.jl#1605.