Breaking changes for the p-adics #1759
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
force-pushed
the
js/padicsbreaking
branch
2 times, most recently
from
3e508c0
to
64a09d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
- Coverage 86.06% 86.01% -0.05%
==========================================
Files 98 98
Lines 36255 36251 -4
==========================================
- Hits 31204 31183 -21
- Misses 5051 5068 +17 ☔ View full report in Codecov by Sentry. |
joschmitt
force-pushed
the
js/padicsbreaking
branch
from
64a09d6
to
30523d9
Compare
|
This needs non-obvious changes in Hecke apparently (maybe these are already in thofma/Hecke.jl#1522, I forgot). So this shouldn't be in the 0.46 breaking release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't forget about this.