More set! methods for fqPolyRepFieldElem #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set parent already in the constructors. Note how all those constructors using set! now have identical implementation besides the differing argument types.
fingolfin
force-pushed
the
mh/fqPolyRepFieldElem-setter
branch
from
84583ef
to
6b3c226
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1810 +/- ##
==========================================
- Coverage 85.96% 85.95% -0.01%
==========================================
Files 98 98
Lines 36380 36388 +8
==========================================
+ Hits 31274 31279 +5
- Misses 5106 5109 +3 ☔ View full report in Codecov by Sentry. |
lgoettgens
approved these changes
Jun 28, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also set parent already in the constructors.
Note how all those constructors using set! now have identical implementation besides the differing argument types.