Remove "call sync" interface for CLI #1370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fails (usually with "cannot yield across c-call boundary") then fallback to running the command and awaiting the result. Hopefully this should remove some confusion around which interface to use, and will prefer async at all times unless that doesn't work.
CKolkey
force-pushed
the
remove-call_sync-interface
branch
from
17276db
to
214f2fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just try to run async, and if that fails (usually with "cannot yield across c-call boundary") then fallback to running the command and awaiting the result.
Hopefully this should remove some confusion around which interface to use, and will prefer async at all times unless that doesn't work.
Hopefully no side effects.
Could probably be refactored to contain this logic in the process class.