Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor watcher + Remove call_sync interface #1386

Merged
merged 36 commits into from
Jun 25, 2024
Merged

Refactor watcher + Remove call_sync interface #1386

merged 36 commits into from
Jun 25, 2024

Conversation

CKolkey
Copy link
Member

@CKolkey CKolkey commented Jun 19, 2024

No description provided.

@CKolkey CKolkey mentioned this pull request Jun 19, 2024
Closed
@CKolkey CKolkey changed the title Refactor watcher Refactor watcher + Remove call_sync interface Jun 19, 2024
actionshrimp and others added 26 commits June 25, 2024 10:28
@actionshrimp @CKolkey
fix(watcher): return self from start
5e78ae2
@actionshrimp @CKolkey
feat(buffer/refs): wire up watcher/refresh
f2d998a
@actionshrimp @CKolkey
rename: {status_,}buffer to reflect new usage
ad402f4
@actionshrimp @CKolkey
buffer/refs: add mapping for refresh
7431ff7
@actionshrimp @CKolkey
dont always go back to status for branch actions
e264532
@actionshrimp @CKolkey
fix(buffer/refs): stable sort order of remotes
f9bba8f
@actionshrimp @CKolkey
add mappings for fetch popup
7b6a9e5
@CKolkey
Modify watcher so multiple buffers can register with a single watcher
33eeafc 
instance.

Extract debouncing logic from buffers - this will move to the repo.
@CKolkey
Add refresh lock and throttle to repo to try to control how frequently
dc7c475 
it triggers
@CKolkey
Performance improvements when parsing records
4441b48
@CKolkey
Performance improvements - it's not clear we _need_ to escape control
2d88ce1 
characters in this output. At least, I can't seem to find any issues
with removing this. Famous last words, I suppose.
@CKolkey
Use dispatch here
8a999f7
@CKolkey
Improve logging timestamps
0b91349
@CKolkey
Add events for branch create/checkout
4a83cec
@CKolkey
Add in_merge and in_rebase helpers for checking state via lib api
ea18fc2
@CKolkey
Escape CLI output when checking lines for interactive output. Otherwise
d384d21 
the matching wont work.
@CKolkey
Allowing registering buffers with Watcher as a kind of a buffer manager
f4f61f1 
that can send a refresh/redraw to any buffers on events
@CKolkey
Refactor registry to allow registering callbacks when a second redraw
bcb4b3e 
command comes in while its already mid refresh.

Extract "redraw" function from "refresh" to allow watcher to just do
one, not both.

Refresh status buffer when refocused
@CKolkey
Use rebase helper
4316e33
@CKolkey
Remove process result.stdout_raw - we no longer strip escape codes
ba2c888
@CKolkey
Remove show_popup() for CLI - it didn't do anything
e0f8a55
@CKolkey
Fire stash event
6231297
@CKolkey
remove comment
bc8c70b
@CKolkey
Lint
8c45182
@CKolkey
Remove "call_sync" interface in favor of handling c-call errors inline
b565bdc
@CKolkey
Fix spec - we don't strip the ctrl chars
3b55e13
@CKolkey CKolkey merged commit 74cb71b into master Jun 25, 2024
5 checks passed
@CKolkey CKolkey deleted the refactor-watcher branch June 25, 2024 08:29
@ktsujister ktsujister mentioned this pull request Jun 25, 2024
Closed
@rami3l rami3l mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CKolkey @actionshrimp