Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing Neogit command #380

Merged
merged 11 commits into from
Oct 27, 2022
Merged

Conversation

ten3roberts
Copy link
Member

Fixes #379, an overlook of #358

@ten3roberts
Copy link
Member Author

This makes the Neogit command accessible after neogit.setup is called.

I am unsure if it should be kept that way or if it should always be sources, regardless if setup was called.

Any opinions would be greatly appreciated.

Other than that, the fix is done, and it would just be a matter of moving the neogit.commands.setup to plugin/neogit.lua

Copy link
Collaborator

@TimUntersberger TimUntersberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO moving the neogit.commands.setup call into plugin/neogit.lua feels cleaner, but I'm fine with both. 👍

@ten3roberts
Copy link
Member Author

The neogit command has now been moved to plugin/.

The highlighting issues encountered on OS X should now also be fixed

@TimUntersberger TimUntersberger merged commit 1acb13c into NeogitOrg:master Oct 27, 2022
@kristiankupsch
Copy link

Hi. Sadly some of the highlighting issues on OS X are still there.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:Neogit command is missing
3 participants