Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expend version info intent #58

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Expend version info intent #58

merged 2 commits into from
Aug 4, 2023

Conversation

strugee
Copy link
Contributor

@strugee strugee commented Jul 29, 2023

Description

I just tried the "running" phrasing and Neon misinterpreted and started the "Call me Neon AI..." dialog.

Issues

N/A

Other Notes

N/A

@strugee
Copy link
Contributor Author

strugee commented Jul 29, 2023

Just realized I should've fixed more of the file - amended patch pushed. The specific phrase Neon misinterpreted (since it's no longer obvious from the diff) was "what version are you running".

@NeonDaniel
Copy link
Member

Looks like a great addition! Could you add a test case here to make sure the intent matches as expected?

@strugee
Copy link
Contributor Author

strugee commented Aug 1, 2023

Done! I added a few (roughly one for each additional line).

@NeonDaniel NeonDaniel merged commit 8c09f6e into NeonGeckoCom:dev Aug 4, 2023
13 checks passed
@strugee strugee deleted the patch-1 branch August 4, 2023 22:59
@github-actions github-actions bot mentioned this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants