-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2-Step Verification for account login #206
Comments
Will be very useful security layer, especially when handling licences, contracts and NCR. Google Auth is the gold standard of 2-Step - we don't have to look any further. There should be a last resort to remove it if the user really cant reach his backup codes -- trough neos support, but certainly only after email/phone confirmation and some heads-up alters sent to all of his registered contacts during a hefty waiting period. |
Please do not require third party services like Google / SMS for auth. It doesn't offer the security you think it does. "Gold Standard" maybe to Google. |
I believe what @JohannAmos means is using a TOTP based method, instead of rolling their own app or using email tokens. read more about TOTP here: https://en.wikipedia.org/wiki/Time-based_One-time_Password_algorithm |
I don't think so, given they literally said Google. Requiring OTP for 2FA would be a royal PITA. If you look at existing deployments many of them resort to saving logins because of it too which defeats the point. Discord is a good example of what NOT to do. Not sure how that would even work in VR, tell people they need to pull their headset off because you need to grab the token? I'd hope not. |
TOTP would be ok. It doesnt rely or depend on google and has many open source implementations. |
"Google Auth" is not restricted to OTP, they have their own set of requirements for account creation, access, etc. |
Just wanted to kindly poke this again, account security is important to me. |
Yes especially after the MMC. As time goes on, the risk climbs. |
Bumping this. I'd really like to see two factor auth. It's a very important step to increase security. |
bump from me too, something i would like to see |
Fully agree, this should definitely be addressed before Neos's marketplace goes live. |
Agreed. It would be excellent to be able to use my Yubikey to secure my account; failing that, a plain old TOTP scheme would be fine, too. |
I've got this mostly implemented now, but we ran into unexpected issue - enabling this for account login will require updating account.neos.com, but since that's managed by 3rd party developer, that will probably take a while to get updated. We have a few options now:
Any thoughts on those? Or potential alternatives? Also here's demonstration of what's implemented in action. Obviously the codes shown in the video were scrapped and I'll generate myself some fresh ones: |
This has now been released in 2021.7.21.127! Works for any NCR/KFC transactions and optionally for login. Right now login breaks account.neos.com, but can be enabled/disabled with a command, so that should provide good enough workaround. I'm closing this issue now, any additional features and improvements can now be more focused issues. Copying notes from the release with more info:
|
Has account.neos.com been updated for 2FA? If not, is there a github issue to link here? If not, can a github issue be created? |
Please refer to my two comments above. You can also use /webLogin command in Neos to temporarily disable the 2FA login. Long term we'll likely replace account.neos.com with auth.neos.com but it needs more work. |
Thanks, I added this to the wiki! |
Add 2-Step Verification for account login using the Google Authentication standard.
Would be an option the user can turn on under there account options, and would not be forced on the user, but suggested for better account security.
The text was updated successfully, but these errors were encountered: