Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a Protocol generic classes #32

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

akhundMurad
Copy link
Contributor

Merge request fixes the issue: #31

@RobertoPrevato
Copy link
Member

RobertoPrevato commented Mar 9, 2023

@akhundMurad
thank you for your contribution, but Protocol is already supported. The problem is another one, that Protocol without __init__ method defined generates a catch-all constructor (__init__(*args, **kwargs)). I still want rodi to raise exception for such constructors because they are ambiguous for a DI container.

Please read my two comments here:

#31 (comment)

#31 (comment)

@RobertoPrevato RobertoPrevato reopened this Mar 9, 2023
@RobertoPrevato RobertoPrevato merged commit dd0e56e into Neoteroi:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants