Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Root #6

Merged
merged 4 commits into from
Aug 23, 2017
Merged

Multi-Root #6

merged 4 commits into from
Aug 23, 2017

Commits on Aug 21, 2017

  1. update tests for missingAncestorTree ("mat")

    - make the tree a little bit more tricky
    - correct existing "mat"-tests
    - add some more scenarios
    
    Signed-off-by: Patrik Kullman <patrik.kullman@neovici.se>
    Patrik Kullman committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    20b93ac View commit details
    Browse the repository at this point in the history
  2. add multi root support for getPathNodes

    - old method renamed _getPathNodes
    -- fix for nodes on path logic
    - make sure we try to find to path on all root nodes
    -- the path with the least amount of 'undefined' wins
    --- should really be 0 unless something is badly configured
    ---- all undefined from the beginning of the path is excluded to
         account for missing ancestors
    
    Signed-off-by: Patrik Kullman <patrik.kullman@neovici.se>
    Patrik Kullman committed Aug 21, 2017
    7 Configuration menu
    Copy the full SHA
    bde8286 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2017

  1. Configuration menu
    Copy the full SHA
    d66ad2c View commit details
    Browse the repository at this point in the history
  2. Sort by defined values first

    - Adjusted sort of getPathNodes
    - Return tree if !pathLocator
    - added node to test tree: The response object of iron-ajax gets sorted (I guess not guaranteed) by its object keys. Therefore it was hard to let the test fail if same amount of undefined values but not equal amount of defined values. The test case took randomly the right node.
    JaySunSyn committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    af6855c View commit details
    Browse the repository at this point in the history