Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): updated dependencies #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CarloBar1
Copy link

@CarloBar1 CarloBar1 commented Nov 10, 2023

DevStory AB#13151 - update of the public component cosmoz-treenode, moving to Storybook.

@CarloBar1 CarloBar1 marked this pull request as ready for review November 10, 2023 10:44
@CarloBar1 CarloBar1 self-assigned this Nov 10, 2023
@CarloBar1 CarloBar1 added enhancement dependencies Pull requests that update a dependency file labels Nov 10, 2023
@@ -1,69 +0,0 @@
<!doctype html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to preserve these and put then into a storybook maybe.
in the story book load the json ownerTree and set it as property to each instance of cosmoz-treenode.

@megheaiulian megheaiulian self-requested a review November 14, 2023 06:42
Copy link
Contributor

@megheaiulian megheaiulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to have a storybook.
This needs to call the storybook workflow.

@@ -0,0 +1,108 @@
<!DOCTYPE html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a single storybook with all the examples above in it.

jobs:
build:
uses: Neovici/cfg/.github/workflows/forge.yml@master
secrets: inherit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline at the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants