Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial e2e tests #19

Merged
merged 20 commits into from
Jul 4, 2018
Merged

Add initial e2e tests #19

merged 20 commits into from
Jul 4, 2018

Conversation

katcipis
Copy link
Collaborator

@katcipis katcipis commented Jun 28, 2018

We have our basic end to end test comparing the result of "console.log(666)" from v8 to abad =)

@katcipis katcipis self-assigned this Jun 28, 2018
@katcipis katcipis requested a review from i4ki June 28, 2018 22:32
@codecov-io
Copy link

codecov-io commented Jun 28, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@968856d). Click here to learn what that means.
The diff coverage is 1.04%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   49.77%           
=========================================
  Files             ?       23           
  Lines             ?     1531           
  Branches          ?        0           
=========================================
  Hits              ?      762           
  Misses            ?      716           
  Partials          ?       53
Impacted Files Coverage Δ
tests/fixture/fixture.go 0% <0%> (ø)
cmd/abad/main.go 0% <0%> (ø)
abad.go 52.84% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968856d...67c02c7. Read the comment docs.

@katcipis katcipis changed the title WIP: Add initial e2 e tests Add initial e2 e tests Jul 3, 2018
@katcipis katcipis requested a review from ryukinix July 3, 2018 19:02
@ryukinix ryukinix changed the title Add initial e2 e tests Add initial e2e tests Jul 3, 2018
Copy link
Contributor

@ryukinix ryukinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way that tool works for testing it's neat. I'm just wondering why the travis is failing here:

docker: Error response from daemon: pull access denied for neowaylabs/abadev, repository does not exist or may require 'docker login'.

May you need add credentials in the setup for pre-built pull to dockerhub?

@katcipis
Copy link
Collaborator Author

katcipis commented Jul 3, 2018

@ryukinix It is because I'm still uploading the image here =(. It is more than 4GB to upload (YES THE WEB !!).

@katcipis katcipis merged commit 85bc289 into master Jul 4, 2018
@katcipis katcipis deleted the addInitialE2ETests branch July 4, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants