-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PReact 代码压缩后,video 标签的 controls 属性设置 false 不生效 #12589
Comments
taro-bot2
bot
added
F-react
Framework - React
T-weapp
Target - 编译到微信小程序
V-3
Version - 3.x
labels
Sep 28, 2022
经调试发现,该 commit 6065b1c 修复时未兼容代码压缩后的问题。导致 node._dom 获取到 undefined。 建议方案把下面代码 const dom = newVNode._dom 改为 const domProp = Object.keys(newVNode).find(k => (newVNode[k] && newVNode[k].setAttribute));
const dom = newVNode[domProp]; |
@wenshin 感谢反馈并定位,可以直接提一下 PR 哈~ 另外改为 |
wenshin
pushed a commit
to wenshin/taro
that referenced
this issue
Oct 3, 2022
17 tasks
已经提 PR |
17 tasks
Chen-jj
added a commit
that referenced
this issue
Oct 16, 2022
KkZsc
pushed a commit
to KkZsc/taro
that referenced
this issue
Dec 5, 2022
* fix(preact): 修复 PReact 压缩后属性设置不生效问题 (NervJS#12589) * fix: ci * fix: ci Co-authored-by: yanwenxu17158 <yanwenxu17158@ipalfish.com> Co-authored-by: chenjiajian <798095202@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
相关平台
微信小程序
复现仓库
https://github.com/wenshin/taro-issue-demo
小程序基础库: 2.26.1
使用框架: React
复现步骤
期望结果
在 devtools 和真机都不能看到原生控制器
实际结果
在 devtools 和真机都能看到原生控制器
环境信息
The text was updated successfully, but these errors were encountered: