Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(weapp): support scroll-view refresher-two-level #14573

Merged
merged 3 commits into from
Sep 22, 2023
Merged

feat(weapp): support scroll-view refresher-two-level #14573

merged 3 commits into from
Sep 22, 2023

Conversation

TheKonka
Copy link
Member

@TheKonka TheKonka commented Sep 20, 2023 •
edited
Loading

#14321

这个 PR 做了什么? (简要描述所做更改)
支持微信小程序下拉二级功能

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix 是否支持微信小程序“下拉二级” #14321
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

ZakaryCode
ZakaryCode requested changes Sep 22, 2023
View reviewed changes
packages/taro-components/types/Slot.d.ts Outdated
@@ -11,6 +11,7 @@ interface SlotProps {
* @supported swan
*/
varName?: string
children?: ReactNode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该 extends StandardProps，而不是直接使用 children

packages/taro-components/types/ScrollView.d.ts
@@ -252,6 +306,30 @@ declare namespace ScrollViewProps {
/** 滚动速度 */
velocity: number
}
const enum RefreshStatus {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum 类型会影响文档解析，应当尽可能避免

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了下微信的文档，还是考虑保留此处 enum

@ZakaryCode ZakaryCode merged commit a59ea60 into NervJS:next Sep 22, 2023
4 checks passed
@TheKonka TheKonka deleted the fix/scrollview-two-level branch September 22, 2023 08:00
@taro-bot2 taro-bot2 bot mentioned this pull request Sep 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

是否支持微信小程序“下拉二级”
2 participants
@TheKonka @ZakaryCode