Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

获取scrollTop报错处理 #14801

Merged
merged 7 commits into from
Jan 15, 2024
Merged

获取scrollTop报错处理 #14801

merged 7 commits into from
Jan 15, 2024

Conversation

qnnp-me
Copy link
Contributor

@qnnp-me qnnp-me commented Nov 9, 2023

修复获取scrollTop 的 error 不可控问题

Copy link

taro-bot2 bot commented Nov 9, 2023

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

packages/taro-extend/src/jquery/zepto.js Outdated Show resolved Hide resolved
packages/taro-extend/src/jquery/zepto.js Outdated Show resolved Hide resolved
@Chen-jj
Copy link
Contributor

Chen-jj commented Nov 9, 2023

@qnnp-me 麻烦修改一下格式问题

@Chen-jj
Copy link
Contributor

Chen-jj commented Jan 15, 2024

感谢贡献~

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df53aae) 53.98% compared to head (4b6e692) 53.98%.
Report is 6 commits behind head on main.

❗ Current head 4b6e692 differs from pull request most recent head ecabcf1. Consider uploading reports for the commit ecabcf1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #14801    +/-   ##
========================================
  Coverage   53.98%   53.98%            
========================================
  Files         495      495            
  Lines       22823    22823            
  Branches     6004     6005     +1     
========================================
  Hits        12322    12322            
+ Misses       9148     8948   -200     
- Partials     1353     1553   +200     
Flag Coverage Δ
taro-cli 63.29% <ø> (ø)
taro-runner 46.22% <ø> (ø)
taro-runtime 65.51% <ø> (ø)
taro-web 41.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

@Chen-jj Chen-jj merged commit 523bf1b into NervJS:main Jan 15, 2024
11 checks passed
weizs pushed a commit to weizs/taro that referenced this pull request Jan 15, 2024
* 获取scrollTop报错处理

* 获取scrollTop报错处理

---------

Co-authored-by: qnnp <wjp@pfan.ltd>
Co-authored-by: chenjiajian <798095202@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants