Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

增加 Rust 桥接 && taro init 部分使用 Rust 改造 #14870

Merged
merged 19 commits into from
Dec 11, 2023
Merged

增加 Rust 桥接 && taro init 部分使用 Rust 改造 #14870

merged 19 commits into from
Dec 11, 2023

Conversation

luckyadam
Copy link
Member

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

@taro-bot2 taro-bot2 bot mentioned this pull request Nov 25, 2023
Closed
Chen-jj
Chen-jj reviewed Dec 7, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
Chen-jj
Chen-jj reviewed Dec 7, 2023
View reviewed changes
rustfmt.toml
@@ -0,0 +1,2 @@
tab_spaces = 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust 官方建议的缩进风格是 4 个空格

Chen-jj
Chen-jj reviewed Dec 7, 2023
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
crates/native_binding/Cargo.toml Outdated
crate-type = ["cdylib"]

[dependencies]
napi = { workspace = true, features = ["napi4", "tokio_rt"]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

常用的 features 可以改为在 workspace 设置？这样就不用每个成员包都设置了

Chen-jj
Chen-jj reviewed Dec 7, 2023
View reviewed changes
packages/taro-cli/package.json Outdated
@@ -56,8 +57,6 @@
"joi": "^17.6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI 的 joi 依赖应该可以干掉了？

@luckyadam
feat: 增加 rust 桥接模块
87602db
@luckyadam
feat: 实现创建项目逻辑
3700413
@luckyadam
feat: 完善项目创建流程
1a0eac9
@luckyadam
fix: 修复创建 rn 项目报错
24cb315
@luckyadam
chore: 格式化代码
ddd6d3e
@luckyadam
feat: 完善创建项目/页面/插件
3b9c2b7
@luckyadam
fix: 修复 convert 问题
2441b98
@luckyadam
fix: 修复 convertor 问题
2435df9
@luckyadam
fix: 修复 convertor 问题
fe9d514
@luckyadam
feat: 更新 CI 配置
755163e
@luckyadam
fix: 修复编译 binding 的 CI 配置
815a704
@luckyadam
chore(release): publish 3.6.19-nightly.20231122 --tag=nightly --acces…
05c83b9 
…s=public
@luckyadam
chore(release): publish 3.6.19-nightly.2023112217 --tag=nightly --acc…
10e9608 
…ess=public
@luckyadam
chore(release): publish 3.6.19-nightly.2023112221 --tag=nightly --acc…
1b52528 
…ess=public
@luckyadam
chore(release): publish 3.6.19-nightly.2023112223 --tag=nightly --acc…
97481b8 
…ess=public
@luckyadam
chore: merge next
30f434b
Chen-jj
Chen-jj reviewed Dec 8, 2023
View reviewed changes
crates/taro_init/src/async_fs.rs
Box::pin(fut)
}

pub fn create_dir_all<P: AsRef<std::path::Path>>(dir: P) -> BoxFuture<'static, Result<()>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AsRef

Chen-jj
Chen-jj reviewed Dec 8, 2023
View reviewed changes
crates/taro_init/src/async_fs.rs
Box::pin(fut)
}

pub fn write<P: AsRef<std::path::Path>, D: AsRef<[u8]>>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AsRef

@taro-bot2 taro-bot2 bot mentioned this pull request Dec 9, 2023
Closed
@luckyadam luckyadam merged commit 61404e1 into main Dec 11, 2023
31 of 34 checks passed
@luckyadam luckyadam deleted the feat/init_rs branch December 11, 2023 02:37
@taro-bot2 taro-bot2 bot mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chen-jj Chen-jj Chen-jj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luckyadam @Chen-jj