New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): 创建文件夹统一使用 fs.ensureDirSync #2576

Merged

luckyadam merged 1 commit into NervJS:master from js-newbee:taro-fs-mkdir

Mar 25, 2019

Contributor

js-newbee commented Mar 25, 2019

taro-cli/src/build.js 中使用 fs.mkdirSync(outputPath) 可能有问题，如果 outputRoot 是包含子目录的，如 dist/weapp，编译会报错
fs. mkdirpSync、fs.ensureDirSync 内部实现都是 fs.mkdirsSync，既然项目中多数都用 fs.ensureDirSync 了，那没必要单独某个地方用 fs. mkdirpSync
既然第 2 点可行，那其他地方也顺便统一都改掉哈

js-newbee force-pushed the taro-fs-mkdir branch from d4071fa to 566a044 Compare

March 25, 2019 11:02

js-newbee changed the title ~~refactor: 创建文件夹统一使用 fs.ensureDirSync~~ refactor(cli): 创建文件夹统一使用 fs.ensureDirSync


          refactor(cli): 创建文件夹统一使用 fs.ensureDirSync

566a044

Member

luckyadam commented Mar 25, 2019

OJBK！

luckyadam merged commit 3589621 into NervJS:master

taro-bot bot mentioned this pull request

项目周报 (2019 年 3 月 23 日 - 2019 年 3 月 30 日) #2635

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet