Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(h5): taro-h5的api没有挂载到export default Taro上 #3581

Closed
wants to merge 2 commits into from

Conversation

lbb00
Copy link

@lbb00 lbb00 commented Jun 28, 2019

这个 PR 做了什么? (简要描述所做更改)

taro-h5的api没有挂载到Taro上

这个 PR 是什么类型? (至少选择一个)

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

@lbb00 lbb00 changed the title fix(taro-h5): taro-h5的api没有挂载到Taro上 fix(h5): taro-h5的api没有挂载到Taro上 Jun 28, 2019
@lbb00 lbb00 changed the title fix(h5): taro-h5的api没有挂载到Taro上 fix(h5): taro-h5的api没有挂载到export default Taro上 Jun 28, 2019
@lbb00
Copy link
Author

lbb00 commented Jun 28, 2019

@yuche 有个报错

@luckyadam
Copy link
Member

@lbb00
Copy link
Author

lbb00 commented Jun 30, 2019

这里的Taro没有Taro. setClipboardData这些属性

@lbb00
Copy link
Author

lbb00 commented Jul 1, 2019

你看我的测试用例大概就能明白了

@Littly
Copy link
Contributor

Littly commented Jul 1, 2019

这个问题是因为在@tarojs/taro-h5中,setClipboardData函数的名字被错写成setClipBoardData了,主干中已经修复:e6fe90f

这些散装api是故意不放在default中导出的,因为会影响到对@tarojs/taro-h5的treeshaking。目前之所以能使用Taro.xxx来调用这些api,是因为我们用babel插件做了转换:

[
require.resolve('babel-plugin-transform-taroapi'),
{
apis,
packageName: '@tarojs/taro-h5'
}
]

@Jeff-Tian
Copy link
Contributor

升级 到 3.6.4 之后又出现这个问题:

[Error: tarojs_taro__WEBPACK_IMPORTED_MODULE_4_.default.getStorageSync is not a function]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants