Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复RN中Image组件的mode为widthFix时图片首次加载可能不显示的问题，修复ScrollView在设置了scrollTop后滚动抖动的问题 #6036

Merged
merged 8 commits into from
Jul 30, 2020
Merged

fix: 修复RN中Image组件的mode为widthFix时图片首次加载可能不显示的问题，修复ScrollView在设置了scrollTop后滚动抖动的问题 #6036

merged 8 commits into from
Jul 30, 2020

Conversation

aoarashi1988
Copy link

@aoarashi1988 aoarashi1988 commented Apr 18, 2020 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

  • 调整Image中this.state.ratio的更新条件，防止onLayout触发在componentDidMount之前，导致图片高度为0

  • 修改ScrollView中getSnapshotBeforeUpdate的判断条件

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@zhiqingchen
Copy link
Member

+1

@aoarashi1988 aoarashi1988 changed the title fix: 修复RN中Image组件的mode为widthFix时图片首次加载可能不显示的问题 fix: 修复RN中Image组件的mode为widthFix时图片首次加载可能不显示的问题，修复ScrollView在设置了scrollTop后滚动抖动的问题 Apr 25, 2020
@taro-bot taro-bot bot mentioned this pull request Apr 25, 2020
Closed
@aoarashi1988 aoarashi1988 reopened this Apr 25, 2020
@taro-bot2 taro-bot2 bot mentioned this pull request Jul 11, 2020
Closed
@Chen-jj Chen-jj added T-rn Target - 编译到 React Native V-2 Version - 2.x labels Jul 16, 2020
@Pines-Cheng Pines-Cheng requested review from Pines-Cheng and removed request for Manjiz July 29, 2020 07:26
@luckyadam luckyadam merged commit c49aa98 into NervJS:2.x Jul 30, 2020
@taro-bot2 taro-bot2 bot mentioned this pull request Aug 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pines-Cheng Pines-Cheng Pines-Cheng approved these changes

Assignees
No one assigned
Labels
T-rn Target - 编译到 React Native V-2 Version - 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aoarashi1988 @zhiqingchen @Pines-Cheng @luckyadam @Chen-jj