fix(swan): 修复Taro 2.0百度小程序列表渲染bug #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(swan): util添加generateMemberExpressionArray方法
fix(swan): 修复百度小程序列表渲染问题 NervJS#6736
fix(swan): 百度小程序列表渲染添加测试用例
shengbowen
changed the title
Closed
|
本地build都没报错，不知道ci为什么报错~ |
fix(swan): 解决eslint报错
|
@shengbowen 我也遇到相同问题 还没有合并进去吧 急等着用新包 |
luckyadam
approved these changes
Jul 29, 2020
| const keyAttribute: t.JSXAttribute | undefined = attributes.find(a => t.isJSXIdentifier(a.name, {name: 'key'})) | ||
| if (keyAttribute && t.isJSXExpressionContainer(keyAttribute.value)) { | ||
| let itemName = itemId!.name; | ||
| const expressionArray = generateMemberExpressionArray(keyAttribute.value.expression as t.MemberExpression) |
There was a problem hiding this comment.
这里有问题呀，generateMemberExpressionArray 没有引入
| @@ -2144,6 +2144,19 @@ export class RenderParser { | |||
| } | |||
| setJSXAttr(component.node, Adapter.for, t.stringLiteral(`{{${forExpr}}}`)) | |||
| } | |||
| } if (Adapters.swan === Adapter.type) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
这个PR 主要是为了修复百度小程序列表渲染，不支持s-key属性的bug
这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台:
其它需要 Reviewer 或社区知晓的内容：
这个修改，只支持单层循环的情况，在某些情况下，需要在列表mount时通过
Taro.setIsUsingDiff(false);取消diff，在unmount中Taro.setIsUsingDiff(true);恢复diff