Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to GetGroupsParams struct #413

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

mattkeeler
Copy link
Contributor

@mattkeeler mattkeeler commented Apr 5, 2023

Adds the Exact and Q fields to the GetGroupsParams struct, to match the API docs. I've also re-ordered the fields in alphabetical order.

The Full field looks like it might be old, as that parameter doesn't exist in the docs. I can remove that as well but wanted to confirm first.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #413 (7b64a51) into main (a521bf0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   77.16%   77.16%           
=======================================
  Files           4        4           
  Lines        2172     2172           
=======================================
  Hits         1676     1676           
  Misses        337      337           
  Partials      159      159           
Impacted Files Coverage Δ
models.go 92.71% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattkeeler
Copy link
Contributor Author

Looks like the tests failed due tcp broken pipe and need to be re-run.

Copy link
Owner

@Nerzal Nerzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@Nerzal Nerzal merged commit 2189847 into Nerzal:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants