Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Active Directory organizational units (OU) #8

Merged
merged 4 commits into from
Jun 12, 2020

Conversation

okrause
Copy link
Contributor

@okrause okrause commented Jun 9, 2020

Complex active directories organise resources like computers and users into sub-partitions, called Organizational Units (OU). This is a common requirement for all, but the smallest, Active Directories.

While the CVS API offers the functionality to set the OU, the current CVS/GCP UI misses that functionality. This PR enables OU handling for the Terraform provider.

Note to maintainers: I also added checks into active directory acceptance tests. I cannot test this, but should work fine without issues. Please note, that you have to add an OU called "engineering" to your test AD, if you want to create volumes after you set OU=engineering. Otherwise SMB volume create will fail, because the OU doesn't exist.

@okrause
Copy link
Contributor Author

okrause commented Jun 10, 2020

Added two commits, with the first being related to OU support and the second one is minor.
7a29ec1 adds support for Active Directory Sites.
5f2d60c fixes a minor bug where changing only the volume name would not be applied.

@lonico lonico merged commit 20f9f37 into NetApp:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants