-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a behaviorspace-experiment-name primitive #657
Comments
I reassigned this ticket to 5.2—mostly as a suggestion. I think it should really go out in the next release, and the proposed primitive doesn't seem difficult to implement (as I described above). The issue has been languishing here for several months, and it solves a problem that users can't really work around by themselves. |
I don't think it's going to get in this release. I'll keep it in 5.x for the time being and revisit later. |
I'm defaulting this to the empty string unless there's a reason to do null |
Empty string makes sense to me. Might also make sense to forbid the Behavior Space GUI forbid the creation of an experiment if the experiment's name is empty. Currently, empty string names are allowed. |
I don't think disabling that is necessary. No harm done. |
I think empty string is fine. At one time I would have been strongly tempted to return |
One other possibility would be to add a |
Especially since that level of revamping is not something I'm going to be able to accomplish by next friday. For a long term solution, would it be better for behaviorspace to be a plugin/extension pair? |
Absolutely. (But as usual, see the discussion in #574 about what that implies, exactly. I know you know already, but I'm including the link for the benefit of anyone else reading these comments.) |
Fix #657. Add behaviorspace-experiment-name prim.
From @alan-isaac:
This doesn't look very difficult to implement.
AbstractWorkspace._behaviorSpaceRunNumber
current holds the run number. I gets initialized byorg.nlogo.lab.gui.Supervisor
, which has aprotocol
member that happens to hold the name of the BehaviorSpace run.One solution would just be to add another variable to
AbstractWorkspace
and store the name in there. Another might be to create some small container class BehaviorSpace settings that lives outside of theorg.nlogo.lab
package, and then store one of those inAbstractWorkspace
for the BehaviorSpace primitives to grab their values out of.The text was updated successfully, but these errors were encountered: