Add primitive insert-item [issue #214]
#1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SethTisue
reviewed
Jan 26, 2017
| @@ -53,6 +53,8 @@ class LogoList private (private val v: Vector[AnyRef]) | |||
| override def reverse = new LogoList(v.reverse) | |||
| def replaceItem(index: Int, obj: AnyRef) = | |||
| new LogoList(v.updated(index, obj)) | |||
| def insertItem(index: Int, obj: AnyRef, elt: AnyRef) = | |||
| new LogoList(v.slice(0, index) ++ Vector(elt) ++ v.slice(index, v.size)) | |||
There was a problem hiding this comment.
would Vector#patch be helpful here?
|
This looks good. There's a few tests still failing (not a bug, the tests just need to be updated). We'll look at the test failures together on Wednesday. |
brotatotes
force-pushed
the
add-primitive-insert-item
branch
from
7823f74
to
28a9fcf
Compare
brotatotes
force-pushed
the
add-primitive-insert-item
branch
from
28a9fcf
to
b7e7b3a
Compare
mrerrormessage
force-pushed
the
add-primitive-insert-item
branch
from
c54bb41
to
f102697
Compare
mrerrormessage
force-pushed
the
add-primitive-insert-item
branch
from
f102697
to
13c4038
Compare
mrerrormessage
force-pushed
the
add-primitive-insert-item
branch
from
13c4038
to
a3a02d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.