Fixes memory leak in traffic_class_test and improves traffic class deletion behavior. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 62.83% (diff: 100%)@@ master #199 diff @@
==========================================
Files 46 46
Lines 2129 2139 +10
Methods 278 278
Messages 0 0
Branches 0 0
==========================================
+ Hits 1334 1344 +10
Misses 795 795
Partials 0 0
|
barath
requested review from
sangjinhan and
changlan
and removed request for
melvinw
|
@changlan This should fix the issue you opened. |
barath
requested review from
melvinw
and removed request for
sangjinhan and
changlan
melvinw
reviewed
Dec 22, 2016
| TrafficClass *c = CT("leaf", {LEAF}); | ||
| ASSERT_TRUE(c != nullptr); | ||
| std::unique_ptr<TrafficClass> c(CT("leaf", {LEAF})); | ||
| ASSERT_TRUE(c.get() != nullptr); |
There was a problem hiding this comment.
minor nit. should use ASSERT_NE here
There was a problem hiding this comment.
Done. Also replaced other similar assertions with ASSERT_NE.
melvinw
approved these changes
Dec 22, 2016
|
Looks good! Will merge once CI finishes |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.