ABI checks have not been run since 3.1.8 #262
Comments
|
@slowfranklin Since you were the last person committing an ABI file, can you comment on whether this QA mechanism is still valid today? I would assume so, and it seems to be a good idea to make sure we don't inadvertently change the behavior of the libatalk interface. |
|
Yes, it's a good idea to do semantic versioning of public libraries and this was initially added to allow external consumers of libatalk safe usage, but no, as afaict there are no external consumers of libatalk I just dropped maintaing the ABI stuff at some point and we can drop this stuff. As an additional change we can then make libatalk a private library. |
|
Now I understand the original intent. Agreed that there is little use in keeping this around. For starters I removed the ABI checking steps from the developer notes wiki page. A few things to clean up:
Anything else? |
|
@slowfranklin Please see if this covers all the bases #269 |
The libatalk binary API versioning scheme was removed after discussion in GitHub #262 and effective with v3.1.16 However, since then, external consumers of libatalk have been found. Additionally, ABI versioning allows distinguishing 3.x libatalk from 2.x libatalk in the wild. Signed-off-by: Daniel Markstedt <daniel@mindani.net>
The libatalk binary API versioning scheme was removed after discussion in GitHub #262 and effective with v3.1.16 However, since then, external consumers of libatalk have been found. Additionally, ABI versioning allows distinguishing 3.x libatalk from 2.x libatalk in the wild. The ABI version has been set to "18" in the Meson build system since release version 3.2.0. Signed-off-by: Daniel Markstedt <daniel@mindani.net>
The libatalk binary API versioning scheme was removed after discussion in GitHub #262 and effective with v3.1.16 However, since then, external consumers of libatalk have been found. Additionally, ABI versioning allows distinguishing 3.x libatalk from 2.x libatalk in the wild. The ABI version has been set to "18" in the Meson build system since release version 3.2.0. Signed-off-by: Daniel Markstedt <daniel@mindani.net>
The libatalk binary API versioning scheme was removed after discussion in GitHub #262 and effective with v3.1.16 However, since then, external consumers of libatalk have been found. Additionally, ABI versioning allows distinguishing 3.x libatalk from 2.x libatalk in the wild. The ABI version has been set to "18" in the Meson build system since release version 3.2.0. Signed-off-by: Daniel Markstedt <daniel@mindani.net>
The libatalk binary API versioning scheme was removed after discussion in GitHub #262 and effective with v3.1.16 However, since then, external consumers of libatalk have been found. Additionally, ABI versioning allows distinguishing 3.x libatalk from 2.x libatalk in the wild. The ABI version has been set to "18" in the Meson build system since release version 3.2.0. Signed-off-by: Daniel Markstedt <daniel@mindani.net>
The libatalk binary API versioning scheme was removed after discussion in GitHub #262 and effective with v3.1.16 However, since then, external consumers of libatalk have been found. Additionally, ABI versioning allows distinguishing 3.x libatalk from 2.x libatalk in the wild. The ABI version has been set to "18" in the Meson build system since release version 3.2.0. Signed-off-by: Daniel Markstedt <daniel@mindani.net>
The ABI check step of the release QA process has not been run since the 3.1.8 release https://github.com/Netatalk/netatalk/wiki/Developer-Notes#abi-checking
The text was updated successfully, but these errors were encountered: