Modernize autotools bootstrapping

[ghost]

This PR:

1. Updates the autoconf syntax in bootstrap and configure.ac and updates all obsolete macros.
2. Fixes the make check error that occurs when AM_INIT_AUTOMAKE([subdir-objects]) is present in configure.ac.

[rdmark]

Great job figuring this out! My eyes go watery every time I try to wrap my head around bootstrap syntax. ;)

Did you test if / how much this breaks backwards compatibility with older autotools? It might be helpful to mention this in future release notes.

[rdmark]

Additionally, these changes reveal the following warnings on Debian Bullseye:

doc/manpages/man1/Makefile.am:35: warning: '%'-style pattern rules are a GNU make extension
doc/manpages/man5/Makefile.am:21: warning: '%'-style pattern rules are a GNU make extension
doc/manpages/man8/Makefile.am:21: warning: '%'-style pattern rules are a GNU make extension

This page talks about pattern rules.

Of course this code change didn't introduce the offending syntax, but it would be a plus to address it for the sake of portability.

[ghost]

Additionally, these changes reveal the following warnings on Debian Bullseye:

doc/manpages/man1/Makefile.am:35: warning: '%'-style pattern rules are a GNU make extension
doc/manpages/man5/Makefile.am:21: warning: '%'-style pattern rules are a GNU make extension
doc/manpages/man8/Makefile.am:21: warning: '%'-style pattern rules are a GNU make extension

This page talks about pattern rules.

Of course this code change didn't introduce the offending syntax, but it would be a plus to address it for the sake of portability.

Fixed in latest force-push

[rdmark]

It is possible to bootstrap, configure and build on recent OpenIndiana, FreeBSD, CentOS, and Debian Bookworm / Bullseye. I think this syntax is good.

[rdmark]

@dgsga May I ask you to squash the commits and mention the GitHub ticket # (#331) in the commit description? It's helpful to have that traceability.

See also: https://github.com/Netatalk/netatalk/wiki/Developer-Notes#commit-messages

[rdmark]

BTW I learned about autoupdate today, which modernizes the autotools syntax, and it found only one minor recommended tweak:

dmark@rasp32:~/dev/netatalk $ autoupdate
dmark@rasp32:~/dev/netatalk $ git diff
diff --git a/configure.ac b/configure.ac
index 324ca503..6be04d09 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,6 +1,6 @@
 dnl configure.ac for netatalk

-AC_INIT([netatalk],m4_normalize(m4_include([VERSION])))
+AC_INIT([netatalk],[m4_normalize(m4_include(VERSION))])
 AC_CONFIG_SRCDIR([etc/afpd/main.c])

 NETATALK_VERSION=`cat $srcdir/VERSION`

[ghost]

@dgsga May I ask you to squash the commits and mention the GitHub ticket # (#331) in the commit description? It's helpful to have that traceability.

See also: https://github.com/Netatalk/netatalk/wiki/Developer-Notes#commit-messages

Done

[rdmark]

@dgsga The macOS job is failing with ld: library not found for -lzlib now...

[ghost]

@dgsga The macOS job is failing with ld: library not found for -lzlib now...

Yes, something unpleasant has happened. Looking into it...

[rdmark]

Still failing on Monterey? What's going on!

[ghost]

Hi @rdmark. It turns out the issue is with a bug in upstream mysql version 8.0.33. A bug fix request has been submitted to the maintainers. In the meantime the macOS workflow installs mysql version 8.0.32, a temporary workaround until the mysql issue is fixed.