Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[2.2] Update atalkd.service to be consistent with other init scripts." #473

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Sep 10, 2023

Reverts #372

I found atalkd and the other appletalk services to be unable to start up when other instances of atalkd run on other hosts on the same LAN.

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rdmark rdmark merged commit c73a766 into branch-netatalk-2-2 Sep 11, 2023
5 checks passed
@rdmark rdmark deleted the revert-372-rdmark-atalkd-service branch September 11, 2023 17:09
rdmark pushed a commit that referenced this pull request Jun 25, 2024
In some configurations, the NBP registrations of "workstation" and "netatalk" may fail. Don't attempt to restart the atalkd service as these are not critical failures. Note, this fixes the issue that lead to these changes being reverted in #473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant