Remove code for obsolete host operating systems #530
Conversation
ghost
linked an issue
include/atalk/globals.h
Outdated
| #ifdef HAVE_NETDB_H | ||
| #include <netdb.h> /* this isn't header-protected under ultrix */ | ||
| #endif /* HAVE_NETDB_H */ |
There was a problem hiding this comment.
Last I checked there were tons more HAVE_NETDB_H checks elsewhere in the codebase. I wonder if all of them can be removed, or if they still serve a purpose for another OS?
There was a problem hiding this comment.
netdb.h is a widely used header in posix oses, and contains definitions for network database operations. macOS and Ubuntu have it for example. So good to keep I think...
There was a problem hiding this comment.
Right, that's what I thought!
So what I wanted to suggest is that we keep the ifdef and just remove the code comment.
I suppose the macro is there for non-posix systems that may not have this header...
#ifdef HAVE_NETDB_H
...
#endif /* HAVE_NETDB_H */
|
Kudos, SonarCloud Quality Gate passed!
|
ghost
deleted the
529-code-for-obsolete-host-oses-still-exists-in-codebase
branch
* Remove unused Tru64 code * Remove unused ultrix code * Remove reference to obsolete OS * Update unix.h defines * Update netatalk.m4 * Update globals.h
* Remove unused Tru64 code * Remove unused ultrix code * Remove reference to obsolete OS * Update unix.h defines * Update netatalk.m4 * Update globals.h
No description provided.