Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code for obsolete host operating systems #530

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Remove code for obsolete host operating systems #530

merged 6 commits into from
Oct 19, 2023

Conversation

dgsga
Copy link
Contributor

@dgsga dgsga commented Oct 15, 2023

No description provided.

@dgsga dgsga linked an issue Oct 15, 2023 that may be closed by this pull request
Code for obsolete host OSes still exists in codebase #529
Closed
@dgsga dgsga requested a review from rdmark October 15, 2023 08:02
@dgsga dgsga self-assigned this Oct 15, 2023
rdmark
rdmark reviewed Oct 15, 2023
View reviewed changes
include/atalk/globals.h Outdated
Comment on lines 14 to 16
#ifdef HAVE_NETDB_H
#include <netdb.h> /* this isn't header-protected under ultrix */
#endif /* HAVE_NETDB_H */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last I checked there were tons more HAVE_NETDB_H checks elsewhere in the codebase. I wonder if all of them can be removed, or if they still serve a purpose for another OS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netdb.h is a widely used header in posix oses, and contains definitions for network database operations. macOS and Ubuntu have it for example. So good to keep I think...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that's what I thought!

So what I wanted to suggest is that we keep the ifdef and just remove the code comment.
I suppose the macro is there for non-posix systems that may not have this header...

#ifdef HAVE_NETDB_H
...
#endif /* HAVE_NETDB_H */

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dgsga dgsga merged commit fa1b4de into main Oct 19, 2023
5 checks passed
@dgsga dgsga deleted the 529-code-for-obsolete-host-oses-still-exists-in-codebase branch October 19, 2023 17:52
dgsga added a commit that referenced this pull request May 19, 2024
@dgsga
Remove code for obsolete host operating systems (#530)
853b60b 
* Remove unused Tru64 code

* Remove unused ultrix code

* Remove reference to obsolete OS

* Update unix.h defines

* Update netatalk.m4

* Update globals.h
dgsga added a commit that referenced this pull request May 19, 2024
@dgsga
Remove code for obsolete host operating systems (#530)
7e05bd3 
* Remove unused Tru64 code

* Remove unused ultrix code

* Remove reference to obsolete OS

* Update unix.h defines

* Update netatalk.m4

* Update globals.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmark rdmark rdmark approved these changes

Assignees

@dgsga dgsga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code for obsolete host OSes still exists in codebase
2 participants
@dgsga @rdmark