Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Swap out the old ldap_init for the wonderful ldap_initialize #767

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Mar 29, 2024

  • Use the more modern ldap_initialize to init LDAP, which enables the use of advanced server URI schemes
  • BREAKING The ldap_server options has been replaced by ldap_uri in afpd.conf and has a new syntax
  • BREAKING Make the build system check for the ldap_initialize symbol, which requires the system ldap library to supply this symbol
  • Update the documentation

@rdmark rdmark marked this pull request as ready for review March 30, 2024 00:05
@rdmark rdmark requested a review from a user March 30, 2024 04:55
Reviewed-by: Ralph Boehme <slow@samba.org>
Copy link

sonarcloud bot commented Mar 30, 2024

@rdmark
Copy link
Member Author

rdmark commented Mar 30, 2024

@dgsga @NJRoadfan I think this is a change that should be made, but it is also a breaking change (afpd.conf syntax, required library), so I'm inclined to hold off on merging this to the stable 2.3 branch.

Rather, I am thinking of planning ahead for a 2.4 feature release in the not too distant future. The mini-roadmap for 2.4 would look something like:

  • Meson build system
  • WolfSSL to bring the DHX UAM back to life
  • This breaking change to LDAP
  • Whatever else that comes up in the meantime

Thoughts?

@rdmark rdmark changed the title [2.3] Swap out the old ldap_init for the wonderful ldap_initialize [2.4] Swap out the old ldap_init for the wonderful ldap_initialize Mar 30, 2024
@ghost
Copy link

ghost commented Mar 30, 2024

I think it's best to target the meson build system for the 2.4 release as there will no doubt be some snagging to do in the early stages of transition. I also agree with not merging this PR until the regressions are fixed. Making the build system check for the ldap_initialize symbol is a piece of cake with meson, I'll add it to my list of jobs.

Now that the meson implementation is nearly done I'm planning replacement of OpenSSL with WolfSSL for both platforms. It's a simple change that requires the addition of one file. Will discuss this as a separate issue.

@rdmark rdmark changed the base branch from branch-netatalk-2-3 to branch-netatalk-2-4 March 31, 2024 10:23
@rdmark rdmark merged commit 77a0c8a into branch-netatalk-2-4 Mar 31, 2024
8 checks passed
@rdmark rdmark deleted the rdmark-issue-762-v2 branch March 31, 2024 10:24
@rdmark
Copy link
Member Author

rdmark commented Mar 31, 2024

@dgsga I have released 2.3.2 now, and subsequently branched branch-netatalk-2-4 to open up for breaking changes.

Please retarget your Meson PR and other active PRs when it's good timing for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant