Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Fix minor syntax error in sys/netatalk/at.h leading to linux headers not being picked up by meson #773

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2024

No description provided.

@ghost ghost requested a review from rdmark March 29, 2024 19:29
@ghost ghost self-assigned this Mar 29, 2024
@ghost ghost changed the base branch from main to branch-netatalk-2-3 March 29, 2024 19:29
Copy link
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ifdef syntax exists in one more place, etc/afpd/unix.h

#if defined(linux) || defined(HAVE_QUOTA_H)

Meson isn't complaining about this one?

@rdmark rdmark changed the base branch from branch-netatalk-2-3 to branch-netatalk-2-4 March 31, 2024 10:26
@rdmark rdmark changed the title [2.3] Fix minor syntax error in sys/netatalk/at.h leading to linux headers not being picked up by meson [2.4] Fix minor syntax error in sys/netatalk/at.h leading to linux headers not being picked up by meson Mar 31, 2024
@ghost
Copy link
Author

ghost commented Mar 31, 2024

This ifdef syntax exists in one more place, etc/afpd/unix.h

#if defined(linux) || defined(HAVE_QUOTA_H)

Meson isn't complaining about this one?

For some curious reason it isn't, maybe it's to do with nested includes. I have changed this one for the sake of consistency.

Copy link

sonarcloud bot commented Mar 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rdmark rdmark merged commit bc031c9 into branch-netatalk-2-4 Mar 31, 2024
8 checks passed
@rdmark rdmark deleted the dgsga-fix-syntax branch March 31, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.3] Syntax error in sys/netatalk/at.h leads to linux headers not being picked up by meson
1 participant