Fix broken cracklib macro in autotools and meson #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
changed the title
ghost
force-pushed
the
dgsga-v3-cracklib
branch
7 times, most recently
from
080f3f0
to
6da51fe
Compare
ghost
marked this pull request as ready for review
ghost
force-pushed
the
dgsga-v3-cracklib
branch
2 times, most recently
from
e96bae4
to
03a9f05
Compare
|
rdmark
approved these changes
May 2, 2024
Comment on lines
+1729
to
+1739
| if fs.is_dir('/usr/share/cracklib') | ||
| cracklib_dict += '/usr/share/cracklib/pw_dict' | ||
| elif fs.is_dir('/var/cache/cracklib') | ||
| cracklib_dict += '/var/cache/cracklib/cracklib_dict' | ||
| elif fs.is_dir('/usr/local/libdata/cracklib') | ||
| cracklib_dict += '/usr/local/libdata/cracklib/cracklib-words' | ||
| elif fs.is_dir('/usr/pkg/share/cracklib') | ||
| cracklib_dict += '/usr/pkg/share/cracklib/pw_dict' | ||
| elif fs.is_dir('/usr/local/share/cracklib') | ||
| cracklib_dict += '/usr/local/share/cracklib/cracklib-small' | ||
| endif |
There was a problem hiding this comment.
Holy moly, this is quite the collection. Did you dig through all the actively supported distros to collect these paths?
|
@dgsga Will you port this to 2.x or should I? |
ghost
pushed a commit
that referenced
this pull request
May 15, 2024
ghost
pushed a commit
that referenced
this pull request
May 15, 2024
|
All done in PR #990 |
rdmark
pushed a commit
that referenced
this pull request
May 16, 2024
ghost
pushed a commit
that referenced
this pull request
May 19, 2024
ghost
pushed a commit
that referenced
this pull request
May 20, 2024
rdmark
pushed a commit
that referenced
this pull request
Jul 20, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP