Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature carousel #39

Closed
cogniSyb opened this issue Aug 16, 2023 · 4 comments
Closed

Feature carousel #39

cogniSyb opened this issue Aug 16, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Aug 16, 2023

A new carousel block, with a text container overlapping an image.

Requirements

  • Section is full width and has a black background
  • On mobile, the image will be shown above the text container
  • Both image and text container will maintain a square aspect ratio (see also V2 Columns block #41)
  • The content in the text container will vertically be centred (see also V2 Columns block #41)
  • Text container content:
    • Eyebrow/pre-heading
    • Heading
    • Text
    • Primary button (optional)
  • On the text container we show the carousel controls
  • When the end of the carousel is reached, either button will be disabled
  • The carousel controls will follow the standard states
  • Scroll-snap will be implemented on mobile, but not on desktop
  • When the carousel only has one slide, we hide the arrows
@cogniSyb
Copy link
Collaborator Author

@Lakshmishri @manuel-vara I just found a related block without the carousel functionality. How would we deal with this?

@cogniSyb cogniSyb added the Question Further information is requested label Aug 16, 2023
@shirin27
Copy link
Collaborator

That might be a carousel with only one slide.

@shirin27 shirin27 added the MVP Must have for october label Aug 18, 2023
@cogniSyb cogniSyb removed the Question Further information is requested label Sep 19, 2023
@DanielaPedrochevd DanielaPedrochevd removed the MVP Must have for october label Oct 23, 2023
@Lakshmishri Lakshmishri self-assigned this Nov 3, 2023
@DanielaPedrochevd DanielaPedrochevd added this to the MT Homepage milestone Nov 3, 2023
@Andrei-Boiangiu
Copy link
Collaborator

confirmed as done

@WendyKruger
Copy link
Collaborator

Just realized this is not what I expected. I believe the original intent of the design was to have the background image change with the carousel click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants