Bump clj-time version to 0.8.0 #76
Conversation
| @@ -21,7 +21,7 @@ | |||
| pigpen.extensions.core)) | |||
|
|
|||
| (deftest test-pp-str | |||
| (let [data {:a "very long string" :b "another really really long string" :c [1 2 3]}] | |||
| (let [data (array-map :a "very long string" :c [1 2 3] :b "another really really long string")] | |||
There was a problem hiding this comment.
Why are these changed? Did the change in clj-time pull in clojure 1.6.0?
There was a problem hiding this comment.
Declared maps {} are not preserving key-value pairs order, array-maps do
this. So this fails one one machine, but may pass on other. Sorry, did not
clarify this in first comment, had to edit.
On Fri, Sep 19, 2014 at 7:28 PM, Matt Bossenbroek notifications@github.com
wrote:
In pigpen-core/src/test/clojure/pigpen/extensions/core_test.clj:
@@ -21,7 +21,7 @@
pigpen.extensions.core))(deftest test-pp-str
- (let [data {:a "very long string" :b "another really really long string" :c [1 2 3]}]
- (let [data (array-map :a "very long string" :c [1 2 3] :b "another really really long string")]
Why are these changed?
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/PigPen/pull/76/files#r17794486.
|
Looked some more & this does pull 1.6.0. I tried last week to upgrade to 1.6.0, but ran into some build/jar issue with instaparse that I don't remember now... Were you able to run this on a hadoop cluster? Longer term I plan to get rid of these dependencies altogether. I barely use them anyway. |
|
Yes, this thing is working for me after fresh gradle build and fresh On Fri, Sep 19, 2014 at 7:58 PM, Matt Bossenbroek notifications@github.com
|
|
Pulled this in today & resolved the issue I was seeing before with 1.6.0. Turned out it was something loading weird in CCW, but fixed it nonetheless. I went to try it out on our clusters & ran into some weird locking problem with the local mode. I'm going to try to merge the rx upgrade that was pending & give it another try after that. I'm also removing the code that needed instaparse & clj-time, so these won't be a problem going forward either. |
|
Fixed by #78 - version 0.2.10 |
Old clj-time version produces a nasty issue in case new version of the lib is used along with PigPen.
See clj-time/clj-time#124
Some tests were failing due to the fact Clojure maps are not guaranteed to preserve kv pairs order. Array- map are doing that. What structure behaviour to choose is up to the developer.