Scala Adaptor #420
Merged
Scala Adaptor #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and tweak build.gradle to make this work
…ava-scala and delete project rxjava-scala-java
…`TimestampedObject`
new Notification class with unapply (scalac crashes)
no more scalac crash
with the following replacements:
\{@link (\w+)#(\w+)\s+(\w+)\}
[[$1.$2 $3]]
\{@link (\w+)#(\w+)\((.*)\)\}
[[$1.$2($3)]]
\{@link #(\w+)\}
[[Observable.$1]]
\{@link (\w+)#(\w+)\}
[[$1.$2]]
<code>
`
</code>
`
\*\s*<p>\s*\n
*\n
\{@link (\w+)\}
[[$1]]
\{@link ((\w|\.)+)\}
[[$1]]
\[\[rx\.
[[rx.lang.scala.
\{@code\s*(([^}])+)\}
`$1`
@param <(\w+)>
@tparam $1
<(\w+)>
[$1]
<(\w+)>
[$1]
"timespan" argument
`timespan` argument
"timeshift" argument
`timeshift` argument
\[\[Action0\]\]
function
plus some manual replacements
rx.lang.scala.concurrency.UnitTest.testInterval fails
|
RxJava-pull-requests #327 SUCCESS |
|
RxJava-pull-requests #328 SUCCESS |
|
I'm just assuming this is all good from your side as I can't provide a useful review on this. |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are more improvements to the Scala adaptor, mostly changes in classes other than
rx.lang.scala.Observableitself, as well as scaladoc for all classes. And theMovieLibexample is now part of therxjava-scalaproject instead of being a seperate project.