Localized Operator Error Handling #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use the lift function rather than try/catch in subscribe since this catches at the operator level rather than for an entire sequence - unit tests with onErrorResumeNext demonstrating the use cases
|
RxJava-pull-requests #866 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Feb 25, 2014
Localized Operator Error Handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do error handling in the
liftfunction rather than try/catch insubscribesince this catches at the operator level rather than for an entire sequence. This then allowsonErrorResumeNextand siblings to handle the error instead of it only being emitted to the finalSubscriber.I derived this fix while working on Hystrix 1.4.