This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
replace hardcoded "owner" with property #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use BasicSimianArmyContext.GLOBAL_OWNER_TAGKEY instead of hardcoded owner I was getting this error trying to run JanitorMonkey with Edda: 2015-10-09 14:58:00.991 -java.lang.RuntimeException: Failed to get valid document from http://localhost:8080/view/instances;_since=1436626680922;state.name=running;tags.key=owner;_expand:(instanceId,tags:(key,value)), got: null Even with janitor.properties containing: simianarmy.janitor.edda.endpoint.us-east-1 = http://localhost:8080/api/v2 And with simianarmy.properties containing: simianarmy.tags.owner = NotOwner
|
SimianArmy-pull-requests #199 SUCCESS |
|
NetflixOSS » SimianArmy » SimianArmy-pull-requests #27 SUCCESS |
ebukoski
added a commit
that referenced
this pull request
Oct 13, 2015
replace hardcoded "owner" with property
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use BasicSimianArmyContext.GLOBAL_OWNER_TAGKEY instead of hardcoded
owner
I was getting this error trying to run JanitorMonkey with Edda:
2015-10-09 14:58:00.991 -java.lang.RuntimeException: Failed to
get valid document from
http://localhost:8080/view/instances;_since=1436626680922;state.name=running;tags.key=owner;_expand:(instanceId,tags:(key,value)),
got: null
Even with janitor.properties containing:
simianarmy.janitor.edda.endpoint.us-east-1 = http://localhost:8080/api/v2
And with simianarmy.properties containing:
simianarmy.tags.owner = NotOwner